http://qs1969.pair.com?node_id=240296


in reply to Re: Re: Simplifying code (Not obfuscation)
in thread Simplifying code (Not obfuscation)

Your test is mixing two different kinds of conditional, the 'if' and the 'or' types.

If/Unless version:

unless ($var = `system thingy`) { die "Failed to get return from call to system\n"; }

Or version:

$var = `system thingy` or die "Failed to get return" from call to syst +em";
Note the use of 'or' instead of ||. The only difference between them is their precendence, but as a result the 'or' doesn't need the braces round the assignment.

Overall good coding style. Nice and readable. If all the code I had to do maintenance on was so readable I'd be a very happy bunny.

Update: Changed the if to an unless since I totally messed up the logic. Oops. Thanks 2mths for pointing that out, shall try and engage brain earlier next time.

Update: Fixed the missing ` problem. Thanks parv. Also updated brain to test all Perlmonks submissions to avoid silly mistakes like this in future.