note
dash2
I don't know if this works - away from my trusty Linuxbox - but it is a good idea. A pure perl [cpan://Archive::Zip] would be a really _brilliant_ idea - great for app packaging.<p>
A few comments just from reading the source:<p>
<ul>
<li>It's a good idea to stick to one subroutine naming convention: <code>like_this</code> or <code>likeThis</code>. In Perl, <code>like_this</code> is preferred as more readable.
<li>You have an OO interface, so why export functions (esp. automatically)? AFAICS <code>Archive::Tar</code> doesn't do this. <li>... especially as you are exporting functions named the same as Perl core functions (e.g. "read")
<li> Hmm... do you come from Java? I don't see anything wrong with using <code>$this</code> instead of <code>$self</code>, it is just a bit unusual.
<li><code>int $verbose == 0</code>: no need. Just <code>and not $verbose</code> would be fine.
<li>Similarly, <code>return unless fileno $filehandle;</code> is fine, and avoids non-standard brackets.
</ul>
<p>I'm just looking for nitpicks, you understand. It seems like very nice, clear code.
248850
248850