Beefy Boxes and Bandwidth Generously Provided by pair Networks
go ahead... be a heretic

Re^3: uninitialized values

by farang (Chaplain)
on Aug 20, 2013 at 04:21 UTC ( #1050120=note: print w/replies, xml ) Need Help??

in reply to Re^2: uninitialized values
in thread uninitialized values

Here's a way to get rid of the warnings, but really you need to reconsider the whole approach used in the while loop. That code is a mess.

By declaring lexical variables inside the loop, they get reset each time through. Move the declarations out of the loop for them to persist.

my (@values1,@val1,@values2,@val2); while (<CMD>) { ...
You will still get one warning from line 1, because the code after the if loop is executed for all lines and @val2 is not yet defined. Adding next can fix that.
my (@values1,@val1,@values2,@val2); while (<CMD>) { if ( $_ =~ /PING/ ){ @values1 = split ; @val1 = split(/\(/,$values1[3]); $val1[1] =~ s/\)//; next; } ...

Again, while these changes avoid the warnings and hopefully show you why they happened, the entire while loop needs a rethink.

Replies are listed 'Best First'.
Re^4: uninitialized values
by gaurav (Sexton) on Aug 20, 2013 at 05:26 UTC

    yes thanks for it,I got it.I am feeling dumb.Hope I won't committed this mistake again

Log In?

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://1050120]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others romping around the Monastery: (4)
As of 2023-02-05 14:10 GMT
Find Nodes?
    Voting Booth?
    I prefer not to run the latest version of Perl because:

    Results (31 votes). Check out past polls.