Beefy Boxes and Bandwidth Generously Provided by pair Networks
Come for the quick hacks, stay for the epiphanies.
 
PerlMonks  

Re^2: my $x or my ($x)

by LanX (Saint)
on Jan 02, 2021 at 23:41 UTC ( [id://11126180]=note: print w/replies, xml ) Need Help??


in reply to Re: my $x or my ($x)
in thread my $x or my ($x)

> This loop never ends!

Because the iterator ->fetchrow_hashref returns one scalar undef when done. But a list assignment (...) = ... is only false if the list is empty. °

It might have been better to return an empty list. This would have worked similarly well in list as scalar context.

But it's only supposed to return one scalar - the mentioned hashref - anyway.

Cheers Rolf
(addicted to the Perl Programming Language :)
Wikisyntax for the Monastery

°) see also Re: list context (iterators)

Replies are listed 'Best First'.
Re^3: my $x or my ($x)
by Bod (Parson) on Jan 03, 2021 at 12:56 UTC
    Because the iterator ->fetchrow_hashref returns one scalar undef when done

    Usually I use fetchrow_array - I don't think I have used fetchrow_hashref before.

    The problem came because I was converting from this code

    my @frames; my $query = $dbh->prepare("SELECT idFrame, name, colour FROM Frame +"); $query->execute(); while (my ($id, $name, $colour) = $query->fetchrow_array) { my $frame = { 'image' => 'test_thumb.jpg', 'id' => $id, 'name' => $name, 'colour' => $colour, }; push @frames, $frame; } my $vars = { 'frames' => \@frames, }; $template->process("admin_frames.tt", $vars);
    It seemed silly to me to be fetching the elements of an array, using those to build an anonymous hash and adding the reference to it to an array. Why not just fetch the hashref and add that to the array?
    my @frames; my $query = $dbh->prepare("SELECT idFrame, name, colour FROM Frame +"); $query->execute(); while (my ($frame) = $query->fetchrow_hashref) { $$frame{'image'} = 'test_thumb.jpg'; push @frames, $frame; } my $vars = { 'frames' => \@frames, }; $template->process("admin_frames.tt", $vars);
    Finding the error of my ($frame) = $query->fetchrow_hashref instead of my $frame = $query->fetchrow_hashref took some time. Not helped by developing it on a webserver so when the loop didn't end, I assumed the connection was just being ultra slow!

    I suspect that there is a more elegant solution that doesn't involve iterating through the rows from the database using fetchall_hashref but that's (possibly) for another day. There will only ever be a handful of rows returned by this query.

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://11126180]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others musing on the Monastery: (2)
As of 2024-04-20 11:59 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found