Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister
 
PerlMonks  

Re^3: Test::More fails...

by haukex (Archbishop)
on May 30, 2023 at 12:19 UTC ( [id://11152513]=note: print w/replies, xml ) Need Help??


in reply to Re^2: Test::More fails...
in thread Test::More fails...

$comp_pass2 should contain a floating point between -1 and +1.

That could explain the problem - What Every Programmer Should Know About Floating-Point Arithmetic. Is compare guaranteed to return the integer 1 in that case, or could it be returning a floating-point number that is so close to 1 that it is just being shown as 1? (see for example)

Replies are listed 'Best First'.
Re^4: Test::More fails...
by Bod (Parson) on May 30, 2023 at 13:13 UTC

    compare will only ever return 1 when the two vectors it is given are identical. In practice, this will almost certainly never happen. If the default model is used, the vectors are 1536 dimensions. For the tests, I have artificially created much smaller, deliberately identical vectors.

    The return value of compare is the return value of cosine in Data::CosineSimilarity

      compare will only ever return 1 when the two vectors it is given are identical. In practice, this will almost certainly never happen.

      Well, it's still good to test the edge cases, as this thread shows.

      The return value of compare is the return value of cosine in Data::CosineSimilarity

      From the source that appears to be the result of a bunch of multiplications and divisions, and assuming there's some floating-point numbers in there, then what I wrote above likely applies. A lot of testing frameworks have functions to compare floating point numbers down to a certain number of decimal places, but it appears this isn't built in to Test::More (though for some reason I remembered incorrectly that it was). Though there's probably a module or two that adds this functionality, a workaround is:

      use Test::More tests=>1; my $x = 1.00000001; is sprintf("%.5f", $x), "1.00000";

        I usually end up using cmp_ok like this:

        cmp_ok abs($have - $want), '<', $tolerance;

        It's so short that I've never bothered to look for another Test::* module to do it.


        🦛

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://11152513]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others taking refuge in the Monastery: (None)
    As of 2024-04-25 00:57 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?

      No recent polls found