is this horrible?

fionbarr has asked for the wisdom of the Perl Monks concerning the following question:

Replies are listed 'Best First'.
Re: is this horrible? by hippo (Bishop) on Feb 16, 2015 at 16:23 UTC
`$os = $1 if ( $description =~ /(windows\|linux\|solaris)/i );`	[reply] [d/l]
Re^2: is this horrible? by ikegami (Patriarch) on Feb 18, 2015 at 21:34 UTC
Better yet if `$os` has no previous value: `my ($os) = $description =~ /(windows\|linux\|solaris)/i;` [download]	[reply] [d/l] [select]
Re^2: is this horrible? by fionbarr (Friar) on Feb 16, 2015 at 16:25 UTC
of course! thanks	[reply]
Re: is this horrible? by Perlbotics (Archbishop) on Feb 16, 2015 at 16:32 UTC
Alternative without statement modifier and with a default ($os always defined): `($os) = ($description =~ /(windows\|linux\|solaris)/i , 'n/a');` [download] Update: Default could be $^O instead of 'n/a', though.	[reply] [d/l]
Re: is this horrible? by choroba (Cardinal) on Feb 16, 2015 at 16:25 UTC
"Horrible" is probably a too strong word. I'd use an alternative in the regex: `$os = $1 if $description =~ /(windows\|linux\|solaris)/i;` [download] لսႽ† ᥲᥒ⚪⟊Ⴙᘓᖇ Ꮅᘓᖇ⎱ Ⴙᥲ𝇋ƙᘓᖇ	[reply] [d/l]
Re^2: is this horrible? by Ratazong (Monsignor) on Feb 16, 2015 at 16:35 UTC
Nice, however it is not the same as the code of the OP. Consider the following code: `my $description = "windows and linux and solaris"; $os = $1 if ( $description =~ /(windows)/i ); $os = $1 if ( $description =~ /(linux)/i ); $os = $1 if ( $description =~ /(solaris)/i ); print $os; $os = $1 if $description =~ /(windows\|linux\|solaris)/i; print " $os\n";` [download] Rata (knowing that this special case is probably excluded by an unwritten part of the spec)	[reply] [d/l]


Think about Loose Coupling
	PerlMonks