Beefy Boxes and Bandwidth Generously Provided by pair Networks
Don't ask to ask, just ask
 
PerlMonks  

Re^7: Tidy up conditions

by martin (Friar)
on Mar 22, 2015 at 02:33 UTC ( [id://1120863]=note: print w/replies, xml ) Need Help??


in reply to Re^6: Tidy up conditions
in thread Tidy up conditions

You stated in your initial post that $item contained a string in the format 'X:Y'. If you were right, that match would of course not fail.

However, if that precondition is dropped and the match is allowed to fail, your new code will put an undefined value $1 into a string when that failure happens. Undef stringifies to an empty string and all may seem well, but your future maintainer might wonder if you did this on purpose or just overlooked an edge case.

How could the match fail? It fails if the first character is a colon or there is no colon at all. You could modify the match so that it still matches part X of an 'X:Y' string but never fails, like this:

$item =~ /^([^:]*)/; $level = $access{$item} // $access{"$1:*"}) // $access{'*'} // 999;

The match will now capture the whole string if there is no colon, and an empty string if the first character is a colon. If you want to assign the "Test:*" level to item "Test" you are done.

If you rather want to assign the "*" level to item "Test" this can also be made foolproof. You could match with colon and look at the success of the match:

my $partial = $item =~ /^([^:]+):/ ? "$1:*" : '*'; $level = $access{$item} // $access{$partial}) // $access{'*'} // 999;

And so on. I am not dogmatic about turning on warnings but consider it good style not to ignore what is defined and what isn't.

Replies are listed 'Best First'.
Re^8: Tidy up conditions
by tel2 (Pilgrim) on Jul 07, 2015 at 23:31 UTC
    Thanks for that, martin. Just noticed your post recently.

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://1120863]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others admiring the Monastery: (6)
As of 2024-04-19 18:03 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found