Beefy Boxes and Bandwidth Generously Provided by pair Networks
Your skill will accomplish
what the force of many cannot

(Ovid) Re: Desperatly seeking the wisdom of the Monks

by Ovid (Cardinal)
on Oct 26, 2001 at 20:14 UTC ( #121659=note: print w/replies, xml ) Need Help??

in reply to Problem with while loop

Hopeless, yes, the code is a mess, but the situation is not as hopeless as your nick would imply. Before we can help you, we need to know what you are looking for. A quick check shows that your code compiles cleanly, so it's not an obvious syntax error. What we need to know is:

  • What sort of input is your script using? (a small sample, please)
  • What output do you want?
  • What output are you actually getting?

Without clear information like that, most of the advice that we can offer is a shot in the dark. However, there are two pieces of advice that I can give right now. First, use strict. All competent Perl programmers will tell you that for a program of significant size, you should almost always be be using strict. Strict will allow you to catch a lot of the typos and other problems which might plague your code (and it did, when I used it for your program.

Second, turn on warnings. If you are using a shebang line, add a -w to the shebang line:

#!/usr/bin/perl -w

If you are using Perl version 5.6 or better (I think that's when it was introduced), you can add "use warnings; to your code.

Just turning on warnings in your code produced some interesting information:

C:\temp>perl -wc Name "main::ccdrive" used only once: possible typo at lin +e 4. Name "main::name" used only once: possible typo at line 6 +8. Name "main::rephash" used only once: possible typo at lin +e 158. syntax OK

As for the command line switches, -w enables warnings and -c tells Perl to compile the program without running it. This is a quick check to see if the program can even attempt to run.

The first warning refers to this line:

$ccdrive = $ENV{CC_DEFAULT_DRIVE};

Since that variable is not used anywhere else in the program, I wonder if this is part of a feature you have not yet implemented?

The second warning refers to this:


Later, you have the following statement twice: push(@vobs, $vobname);. Since $vobname is not initialized anywhere, perhaps the initial assignment should have been to $vobname instead?

The third warning is what may be causing your issue. It refers to the following line:

print TFILE2 "<font color=\"$rephash($ABC[$idx])\"><td> $ABC[$idx] +&nbsp </td> ";

Even though you've already declared a %rephash, it's not going to get recognized here because you need curly braces instead of parentheses. Also, &nbsp; needs a semicolon at the end. Here's a revision of that line:

print TFILE2 "<font color=\"$rephash{$ABC[$idx]}\"><td> $ABC[$idx] +&nbsp; </td>";

In a similar, previous line, you have an error that's not reported:

print TFILE2 "<font color=\$rephash{$replica}\> <td> $rephash{$rep +lica} $DEF[$idx]&nbsp</td>";

The problem there is that you put a backslash directly in front of the dollar sign. When you do that in a string, it tells Perl that you really wanted to print a dollar sign and didn't want the following variable interpolated. The following line is what you intended:

print TFILE2 "<font color=\"$rephash{$replica}\"> <td> $rephash{$r +eplica} $DEF[$idx]&nbsp;</td>";

Hope this helps.


Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.

Log In?

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://121659]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others scrutinizing the Monastery: (4)
As of 2022-11-30 21:08 GMT
Find Nodes?
    Voting Booth?