Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change
 
PerlMonks  

Re^2: Object Identifier? (red flags, more subs)

by damfer21 (Novice)
on Oct 22, 2018 at 12:26 UTC ( [id://1224484]=note: print w/replies, xml ) Need Help??


in reply to Re: Object Identifier? (red flags, more subs)
in thread Object Identifier?

Thanks for the reply and help. I didn't write the code. I only added in $last240_flag. Every other last_flag works as intended.

I don't know the first thing about Perl, just enough about general code to get myself in trouble. I posted the complete code in the reply above. If you have any other recommendations, I would appreciate the help.

  • Comment on Re^2: Object Identifier? (red flags, more subs)

Replies are listed 'Best First'.
Re^3: Object Identifier? (red flags, more subs)
by Veltro (Hermit) on Oct 22, 2018 at 13:21 UTC

    Hi damfer21,

    On first sight I don't see anything wrong with your modification. I just wonder if you also changed the file camp_copy_schedule_save.cgi? I mean, that is where the form action leads to. So I suspect you need to modify that file as well.

    Veltro

      Hi Veltro- I will check that out. Thank you so much. I am really new at this. I am curious about how the script knows that $last120_flag means to include data from the last 120 days. Should there be a file that contains those definitions or are they somehow predefined in the actual script?
        Please check variable $clast60 and your sql table named campaign.

        $sql = "select status,curdate(),max_emails,last60_flag,aol_flag,open_ +flag,yahoo_flag,hour(schedule_time),minute(schedule_time),mid,redirec +t_domain,campaign_nam +e from campaign where campaign_id=$campaign_id +"; $sth = $dbh->prepare($sql); $sth->execute(); ($status,$schedule_date,$max_emails,$clast60,$aolflag,$openflag,$yahoo +_flag,$sho +ur,$smin,$old_mid,$old_dname,$cname) = $sth->fetchrow_arr +ay();

        I agree with the anonymous monk concerning red flags, this code has far too many flaws to justify anything else than a complete rewrite.

        Better don't tell us your website or it'll be hacked within 10 minutes.

        Cheers Rolf
        (addicted to the Perl Programming Language :)
        Wikisyntax for the Monastery FootballPerl is like chess, only without the dice

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://1224484]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others having a coffee break in the Monastery: (4)
As of 2024-04-25 13:43 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found