#!c:\perl\bin\perl -w

use strict;  # you know you wanted this, right?

open(NB, "nbt.csv") or die "Can't open input nbt.csv\n";
# NBT.CSV simply contains ip addresses - one per line

while(<NB>)
    {
    chomp $_;
    my $line="$_".",";      # using my eliminates the undef
    my @nbtstat = `nbtstat -a $_`; # my will make you happy

    for ($j=0; $j<=$#nbstat;$j++)  # $# is the last index
        {
        my $short=substr($nbtstat[$j],0,15);
        chomp $short;
        unless ($line=~m/$short/)
            {$line=$line.",".$short;}
        }
    print "$line\n";
    }
close(NB);
[download]

Update: Could we see an example of the output you are trying to achieve (generated by hand if necessary)?

Piercer, I could not get your script to fail, but we seem to be using different versions of nbtstat.

I looked at your requirements, and although all the suggestions are good ones, it appears I might have something to offer in trying to satisfy all the requirements.

• get the first 15 characters of each line
• no duplicates
• in comma delimited form.

#!c:\perl\bin\perl -w
use strict;

# open(NB, "nbt.csv")|| die"Cant open input file nbt.csv";

# NBT.CSV simply contains ip addresses - one per line
# as DATA sample does

my %stathash = ();

while(my $ip = <DATA>){
    chomp $ip;
    
    #put nbtstat results in an array, one line = one element
    my @nbtstat    = split /\n/, `nbtstat -a $ip`;

    #modify @nbtstat to discard gibberish (if desired)
    for (@nbtstat){
          s/^\s+//g;
          $_       = substr($_,0,15);
          s/[^a-z|A-Z|_|0-9|\040]//g;
          s/\s+$//g;
    }
    # remove duplicates from array
    my %uniq;
    @nbtstat       = grep { ! $uniq{$_} ++ } @nbtstat;

    $stathash{$ip} = \@nbtstat;
}

for my $key (keys %stathash){

  print "\n$key: \n";

  #skip empty elements otherwise print to list
  /.+/ and print "$_," for @{$stathash{$key}};
} 

__DATA__
192.168.0.2
192.168.0.4
192.168.0.5
192.168.0.6
[download]

Result:
192.168.0.2:
Local Area Conn,Node IpAddress,Host not found,
192.168.0.4:
Local Area Conn,Node IpAddress,NetBIOS Remote,Name,OWL,TISIMAGING,MAC Address,
192.168.0.5:
Local Area Conn,Node IpAddress,NetBIOS Remote,Name,DELTA,TISIMAGING,MAC Address,
192.168.0.6:
Local Area Conn,Node IpAddress,NetBIOS Remote,Name,PANAMA,TISIMAGING,MAC Address,

mkmcconn

Tried using strict? It's a good habit to aquire.
I think what you're trying to do can be done with this:

use strict;
open(NB, "nbt.csv") or die "Error reading nbt.csv: $!\n";

while(<NB>){
   chomp;
   @nbtstat = `nbtstat -a $_`;
   %_=map{$_,1}map{/^\d+.\d+\.\d+\.\d+/;$&}($_,@nbtstat);
   print join(',',$_,keys(%_)),"\n";
}
[download]

1. nbtstat each IP address in the file (hopefully XXX.XXX.XXX.XXX, 15 chars ;)
2. Make a list of unique IP addresses (found at the beginning of each line returned)
3. Print the list to STDOUT comma seperated

Note: this'll print the original IP address twice.

--

Brother Frankus.

¤

 {$line=$line.",".$short;}
[download]

 {$line=$lin.",".$short;}   # Oops, $lin should be $line
[download]

buckaduck

Greetings Piercer,

I'm not entirely clear on what you want to gather and display, but from what I understand after reviewing your code, the following may be a solution:

#!/usr/bin/perl -w
use strict;

open(NB, 'nbt.csv') || die "Can't open input file: nbt.csv";
print join "\n", map { chomp; join ',', $_, map { chomp substr($_,0,15
+) } `nbtstat -a $_`; } <NB>;
close(NB);
[download]

Essentially, it prints out a bunch of lines, one line per IP address stored in the nbt.csv file. Each line has the first 15 characters of each line returned from the nbtstat command.

-gryphon
code('Perl') || die;