sub changelog {

   if($GMS->getsetting('OTHER','LOGCLEAR') > param("NOWTIME")){
      viewlog("Error: Time-Date mismatch.");
      exit;
   }

   my $filename = $GMS->getsetting('FILE','MEMBERDIRL').'/GMS';

   open(logfile,"$filename.log") or $GMS->dienice("Unable to open log 
+file!");
   flock(logfile,2) if($GMS->getsetting('OTHER','FLOCK'));
   my $length = scalar(@{[<logfile>]})-1;
   seek(logfile,0,0);

   my %lines;
   for(my $i = 1; $i <= $length+1; $i++){
      $lines{$i} = 1 if(param("LINE$i"));
   }

   open(tempfile,">$filename.tmp") or $GMS->dienice("Unable to open te
+mporary file!");
   flock(tempfile,2) if($GMS->getsetting('OTHER','FLOCK'));
   seek(tempfile,0,0);

   my $count = 0;
   while(my $line = <logfile>){
      $count++;
      if($lines{$count}){
         next;
      }else{
         print STDERR "$count kept\n";
      }
      print tempfile $line;
   }

   close(tempfile);
   close(logfile);

   rename("$filename.log","$filename.bak") or $GMS->dienice();
   rename("$filename.tmp","$filename.log") or $GMS->dienice();
   unlink("$filename.bak") or $GMS->dienice();

   $GMS->changesetting('OTHER','LOGCLEAR',time);

   #The GMS object actually does have a filehandle for the 'logfile' i
+n the object
   #however, I have tried manually closing it and there was no differe
+nce.
   $GMS->logaction("Removed elements from log file");

   viewlog("Changes sucessful!");

}
[download]

I'm not sure but AFAIK on some OSes you should release locks creates with flock before closing filehandle. That is add

flock(tempfile, 4);
flock(logfile, 4);
[download]

before closing these filehandles.

P.S. You should avoid using numbers for constants as it is hard to read and is not fail proof. Use symbol names. use Fcntl ':flock' defines for you LOCK_SH, LOCK_EX, LOCK_UN and LOCK_NB constants.

--
Ilya Martynov (http://martynov.org/)

While I wholeheartedly agree with your comment regarding constant usage and symbol names with flock, the question of releasing locks has been discussed previously here - The summary of this thread was that it wasn't necessary to unlock a file if you were about to close the file as the lock will be released by the closure.

 

perl -e 's&&rob@cowsnet.com.au&&&split/[@.]/&&s&.com.&_&&&print'