go ahead... be a heretic | |
PerlMonks |
Re: Fabric calculator - a better way to do it?by jynx (Priest) |
on Dec 06, 2001 at 09:36 UTC ( [id://129858]=note: print w/replies, xml ) | Need Help?? |
A few suggestions, Most of these are rather cosmetic, but they should help readability. Considering how many times you read from STDIN you may want to farm that part out to a subroutine. It would remove clutter from the rest of the code and should be a bit more maintainable later. For structures like %width an array seems to make more sense than a hash. It works either way, but it's probably a good idea to try and use more appropriate tools when possible. Also you can reduce the number of variables you have to keep track of by using a hash for multiple things. For example, your $number_of_* variables in the last section could probably be written as (using a subroutine for getting STDIN): jynx
In Section
Seekers of Perl Wisdom
|
|