Clearly, the "goto-&NAME" form was intended for use by the low-level "magic" (as perrin so aptly put it in Re: Would you use 'goto' here?) of AUTOLOAD, which, just as clearly, is a dispatch function. Since you're also using it for dispatching, it seems on the one hand appropriate.

On the other hand, quite a few responses to this node (in particular, Masem's, in which he says, "I think the fact that you had to explain the special form in your errata to the original message is a good enough reason") seem to indicate that this form of goto may not be widely used enough to consider it an "idiom" (in contrast with some other widely used constructs nevertheless frequently misunderstood by experienced C/C++/Java programmers new to Perl).

If your goal, as you say, is to "optimize for correctness and clarity", then this might not be the ideal solution. How important is the call stack in a production app anyway? Isn't that more to do with debugging than with normal usage?

IMHO, you're much better off switching to:

return edit_office_product(@_) if $query->param('officeID');
[download]

as first suggested by runrig in Re: Would you use 'goto' here? in this thread.

dmm

You can give a man a fish and feed him for a day ...
Or, you can teach him to fish and feed him for a lifetime