sub change {
my $file = shift;
if (-f $file && $file =~ /\.html$/) {
.
.
.
| [reply] [d/l] [select] |
use strict;
use warnings;
use File::Find;
my @dirs = qw( . );
find ( { wanted => \&change, no_chdir => 1}, @dirs );
sub change
{
my $file = $File::Find::name;
if ( -f $file && $file =~ /\.html$/ )
{
open(IN, $file) or warn "CANT OPEN FILE!\n";
my $buffer;
{
local $/ = undef;
$buffer = (<IN>);
}
close IN;
my $changecount = ($buffer =~ s/OLDWORD/NEWWORD/gi);
if ($changecount)
{
open(OPF,">$file") or warn "NOT OPENING FILE FOR MOD, $!\n
+";
print OPF "$buffer";
close OPF;
}
}
}
This could be optimized and shrunk I know, but I'll leave that to the gurus. I hope this helps.
Take care,
bcb
EDITED: Per a notice from Oaklander, the script would enter directories, but was not changing any of the files. A quick modification changed the call to File::Find from
find ( \&change, @dirs ); to find ( { wanted => \&change, no_chdir => 1}, @dirs );.
I tested the code and it works as Oaklander needs.
| [reply] [d/l] [select] |
I tried your script and it only changed the data in the
main directory. It didnt make any changes to the sub directories.
Please advise on how I can get this to work?
| [reply] |
I get an error message with this attempt saying it doesnt like
the 'use warnings;' on line 2. Please advise if I need to add
a 'warnings' module?
Here is the error message:
BEGIN failed--compilation aborted at C:\Perl\bin\find9.pl line 2.
Script:
use strict;
use warnings;
use File::Find;
my @dirs = qw( . );
find ( { wanted => \&change, no_chdir => 1}, @dirs );
sub change
{
my $file = $File::Find::name;
if ( -f $file && $file =~ /\.html$/ )
{
open(IN, $file) or warn "CANT OPEN FILE!\n";
my $buffer;
{
local $/ = undef;
$buffer = (<IN>);
}
close IN;
my $changecount = ($buffer =~ s/FLORIDA/NEWWORD/gi);
if ($changecount)
{
open(OPF,">$file") or warn "NOT OPENING FILE FOR M
+OD, $!\n+";
print OPF "$buffer";
close OPF;
}
}
}
I tried running this without the 'use warnings;' part and it
only changed words in the main directory so I assume I need this
part to work so it changes the sub directories as well? | [reply] [d/l] |
hmmmmm. this is certainly a stubborn little script we're dealing with. alright.
About Warnings
use warnings; is equivalent to putting the little -w at the end of your 'shebang line'. So if your Perl implementation does not grok use warnings' change your script to read #!/usr/bin/perl -w at the top of your code. This will have the same effect. Warnings have the effect of telling Perl you want it to complain about any code that's incorrect or not clear. An example would be (at least until Perl 6 comes out):
Without warnings, Perl will compile and run the following code
# this is a slice, probably not intended
@someList[0] = 'foo';
but with warnings, if you tried to use the above code, Perl will complain:
@someList[0] better written as $someList[0]
which is what you want. Using warnings (either through 'use warnings' or the '-w' flag is one of the most important steps you can take towards being a good Perl programmer.
Back To the Problem At Hand That all being said, 'use warnings;' is not needed to make this script run correctly.
Some Questions
- What version of Perl are you using, and on which platform?
- How big are the directories that you're trying to parse?
- Are the directories local or are they network shares?
And have you tried adding some debugging to the script to see what it's doing? Maybe you want to do something like:
#!/usr/bin/perl -w #alternative warning syntax
use strict;
use File::Find;
#########################################################
# a debugging variable
#########################################################
my $totalChanges;
my @dirs = qw(.);
find ( { wanted => \&change, no_chdir => 1}, @dirs );
sub change
{
my $file = $File::Find::name;
if ( -f $file && $file =~ /\.html$/ )
{
###################################
# debugging print statement
###################################
print "going into $file\n";
my $buffer;
open(IN, $file) or warn "CAN'T OPEN $file!\n";
{
local $/ = undef;
$buffer = (<IN>);
}
close IN;
my $changecount = ($buffer =~ s/FOO/BAR/gi);
if ($changecount)
{
#######################################
# increment debug variable
#######################################
$totalChanges++;
#######################################
# debugging statement
#######################################
print "changed $changecount instances in $file\n";
open(OPF,">$file") or warn "NOT OPENING $file FOR MOD, $!\
+n";
print OPF "$buffer";
close OPF;
}
}
}
###################################################
# debugging statement
###################################################
print "$totalChanges files changed\n";
| [reply] [d/l] [select] |