Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical
 
PerlMonks  

Re: Matrix Reference

by ton (Friar)
on Mar 01, 2002 at 19:24 UTC ( [id://148654]=note: print w/replies, xml ) Need Help??


in reply to Matrix Reference

I have to admit, I clicked on this node because I wanted to see a reference to "The Matrix", e.g. "There is no spoon." But now that I've looked at your code, I thought I'd give some feedback:

  1. use strict. Really. A lot of problems will become apparent if you do.
  2. In populate, you use $element without declaring it (you declare $elements.)
  3. In populate, you use $matrix without declaring it. So $matrix[$element] will always return 0.
  4. Within the main code, you continuously use $row and $col without ever changing them. So you are always indexing at 0, 0. (I assume $length1 and $length2 were initialized elsewhere, otherwise they too are always equal to 0).
  5. Even if $row and $col changed, setting $matrix_ref->[row][$col] to \@test is setting all elements to be a reference to the same array (@test). I'm pretty sure that's not what you want.
Items 2, 3, and 4 would have been immediately obvious had you used strict.

-Ton
-----
Be bloody, bold, and resolute; laugh to scorn
The power of man...

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://148654]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others imbibing at the Monastery: (4)
As of 2024-04-20 02:01 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found