while will execute while a condition evaluates as true. What you want to do is iterate over your params. foreach is one way to do this:

foreach ( $query->param )
{
    # do stuff
}
[download]

However, I would look down on this in a code review (probably) as one typically needs to treat each parameter as a special case and untaint it according to your needs. Iterating over all of the parameters suggests that this is not being done.

Cheers,
Ovid

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.