Re: Net::Telnet

This is a good review of Net::Telnet - I was interested in the bug-report and the problem which you found executing code under -w and so decided to do a little digging.

The problem which you encountered can be replicated on ActiveState Perl build 630 with the following line:

>C:\>perl -MNet::Telnet -w -e "$obj = Net::Telnet->new; $obj->open(Hos
+t => '127.0.0.1');"
Argument "" isn't numeric in numeric gt (>) at C:/Perl/site/lib/Net/Te
+lnet.pm line 2569.
[download]

The problem lies in the _optimal_blksize method of the Telnet.pm module and is not related to ActiveState per se, but the manner by which this method is called from within the new initiation method. The code for the _optimal_blksize method is as follows:

sub _optimal_blksize {
    my ($blksize) = @_;

    return $blksize
    if defined $blksize and $blksize > 0 and $blksize <= 1_048_576;

    8192;
} # end sub _optimal_blksize
[download]

This method is called without any parameters from the Net::Telnet new method and as such the variable $blksize will be undefined. This rightly generates the warning in the return $blksize if defined $blksize and ... line. This is expected behaviour under -w.

A straight-forward fix for this problem under -w execution can be applied by adding the line:

sub _optimal_blksize {
    my ($blksize) = @_;
    $blksize ||= 0;

    return $blksize
    if defined $blksize and $blksize > 0 and $blksize <= 1_048_576;

    8192;
} # end sub _optimal_blksize
[download]

... which can be applied as the following diff patch ...

2568d2567
<     $blksize ||= 0;
[download]

As an aside note, I tested and was unable to replicate this warning with similarly versioned copies of Net::Telnet on Perl 5.6.1 on a i686-Linux system. Perhaps there is something more to this or the way by which warnings are generated?

Comment on Re: Net::Telnet Select or Download Code

Replies are listed 'Best First'.

Re: Re: Net::Telnet
by demerphq (Chancellor) on Jul 11, 2002 at 13:46 UTC

sub _optimal_blksize {
    my ($blksize) = @_;

    return $blksize if $blksize and $blksize > 0 and $blksize <= 1_048
+_576;

    8192;
} # end sub _optimal_blksize
[download]

UPDATE: I put the >0 test back in, to remove the rope that might hang someone trying to use a negative size...

Yves / DeMerphq
---
Writing a good benchmark isnt as easy as it might look.

[reply]
[d/l]


Welcome to the Monastery
	PerlMonks