Perl-Sensitive Sunglasses | |
PerlMonks |
Re: Tact and the Monasteryby kschwab (Vicar) |
on Sep 14, 2002 at 15:02 UTC ( [id://197868]=note: print w/replies, xml ) | Need Help?? |
OTOH.... I'm always leery of these "this other guys code was a mess" comments. Certainly it's sometimes (mostly?) true, but "messy" is in the eye of the beholder. For example, I tend to use lots of temporary variables where they probably aren't needed. I've gotten negative feedback on that. I think, however, that they make the code more maintainable:
Now, the @chars and $salt variables aren't really needed, and I could have done something like: which is more compact, but less readable, IMO. I've also gotten negative feedback on code reviews for overly defensive programming, which again, adds lines of code and generally makes for more "mess". ( additional eval blocks, lots of defined() calls, etc).
In Section
Meditations
|
|