Why your code doesn't work

If all the machines have their C-Drive shared as c$ (and that's a big if, but I don't know your network, and then it's Windows' default sharename anyway), then you will have to escape the $, as in

The rest doesn't need to be escaped.

Ways to improve your code

Using the same approach, but more clean code:

my %paths = ('KaZaA Lite' => 'c$/Program Files/KaZaA Lite/kazaa.exe',
             'KaZaA' => 'c$/Program Files/Kazaa/kazaa.exe');

foreach (@machine) {
    foreach my $key (keys %paths) {
        print "Bah! Someone installed $key on $_!\n"
            if (-e "//$_/$key");
    }
}
[download]

Now, you can scan for additional files very easily, without changing too much of your code (only the hash at the beginning, actually).

Different approaches

You might consider running a portscan against these machines, focusing on ports that are known to be used by p2p software. Yes, it's not failsafe, but it helps. Most users will not bother to customize their install, I guess.

You might also consider scanning the whole network share for suspicious file names, in case the user installs the program in a non-standard location.

if they are your machines and you have administrator passwords you should skip the whole scan the filesystem thing and look for Kazaa* keys in the machines registry.

likewise if it's your network a machine sniffing traffic and logging ports (even inspecting packet data) will give better results. network traffic from P2P apps stick out like a sore thumb regardless of the ports they're configured for.

if you want to stop P2P, lock down the machines and take Administrator password away from users.

"//$_/c$/Program Files/KaZaA Lite/kazaa.exe"
[download]

What if they install Kazaa to a different location? I would definitely try to hide something I'm not supposed to have.

I don't know what port does Kazaa use but would not your firewall be able to tell you that computer X tries to use pert XX or just that it generates too much traffic?

Or maybe if you find out what port does Kazaa use you might try to connect to that port on all computers and if you do get a connection ...

Jenda
Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live.
   -- Rick Osborne

Edit by castaway: Closed small tag in signature

As with install locations, many programs allow users to change which port is used for communications. I'm not sure if Kazaa (evil evil program) allows such configuration, but it is most likely ;)

---

If the above content is missing any vital points or you feel that any of the information is misleading, incorrect or irrelevant, please feel free to downvote the post. At the same time, please reply to this node or /msg me to inform me as to what is wrong with the post, so that I may update the node to the best of my ability.

If it allows them to select it can only allow them to choose from a list. It has to be able to connect to something outside. And I don't think the other party would listen on all ports.

Or maybe not. I never tried to use it. I know though a coleague here did and was soon blocked by our firewall.

Jenda
Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live.
   -- Rick Osborne

Edit by castaway: Closed small tag in signature

• What do you expect this code to do? or,
• What is your definition of 'works'? or,
• How do you know that it is failing?

Hope that helps!

There is no emoticon for what I'm feeling now.

> Michelle:
> ...
> My users aren't very smart.

Never understimate the smartness (or lack of) of your users. ;-)

By the way, I'm Michele with a single 'l', which is a male name in Italian.

Talk to you soon, Michele.

“Every bit of code is either naturally related to the problem at hand, or else it's an accidental side effect of the fact that you happened to solve the problem using a digital computer.”
M-J D

Irregardless of this working or not working, consider carefuly the security (or lack of same) implications of sharing the root of the c: drive, even as a "hidden" share. Constantly, we hear about viruses scanning for shares named c$, and attempting to infect those computers.

Instead of searching for Program Files/Kazaa on them, search for machines that have a //$_/c$/ share, and close them.

C$ is an administrative share, meaning that anyone with administrative privileges on the box can browse the hard drive(s). Those shares are useful; I use the administrative shares all the time, but none of my users can access them. Of course, if you've got a virus running with superuser privileges you're in trouble anyway.

LAI

__END__