Re: Re: a question about working with the forms and array

Hello, thank you very much for your great comments and valued suggestions. I am deeply sorry for not being clear enough on my first attempt. My problem was only to learn why the values I select from my form array are not making it into the text file as they should? The last choice I select is the only value being added to the list at this time. (In the past, I had real name values written in my html form. Passing/controlling these type of values has been so simple.) The below example uses an array made directly from opening a given dir. This confuses me deeply and I have tried so very hard to find the error for weeks... I have again polished things up a bit and followed your advice. Sincerely, I don't yet fully understand how to write all the different methods using perl, (I do promise to study them for the benifit they will bring me)if I may request the example or correction to follow my current coding style. Hope I'm not being to forward, Thank you again in advance for your time and insight. Jim

 
#!/usr/bin/perl -w
use CGI::Carp qw(fatalsToBrowser);

#############################################

$path_to_files = "/home/foo/www/dir";

$script = "$ENV{'QUERY_STRING'}";

#############################################

read(STDIN, $buffer, $ENV{'CONTENT_LENGTH'});
@pairs = split(/&/, $buffer);
foreach $pair (@pairs) {
   ($name, $value) = split(/=/, $pair);
   $value =~ tr/+/ /;
   $value =~ s/%([a-fA-F0-9][a-fA-F0-9])/pack("C", hex($1))/eg;

   $value =~ s/\n/ /g;# added to strip line breaks 

   $FORM{$name} = $value;
}

#############################################

print "Content-type: text/html\n\n";

$query = "$ENV{'QUERY_STRING'}";

if ($query eq "test") {&Display_Form}
elsif ($FORM{'create_list'} eq "Create") {&Create_List}
else {&Display_Form}

#### BEGIN DISPLAY FORM ####

sub Top {
opendir DIR, "$path_to_files" or die "Can't open directory:$!\n"; 
@thefiles = sort(grep(/html$/, readdir(DIR)));
closedir(DIR);
$count = @thefiles;

print "<html>";
print "<head><title>MY SIMPLE FILE SELECTOR</title></head>";

print "<body bgcolor =\"#FFFFFF\" text =\"#000000\" link = \"#808080\"
+ vlink = \"#808080\" alink = \"#808080\">";

print "<center><h2>MY SIMPLE FILE SELECTOR</h2>";

print "<br><br><small><b>The following [$count] files were found in th
+e [$path_to_files] Dir.</b></small><br><br>";
print "</center>";
}

sub Display_Form {
&Top;
print "<center><table width=\"246\">";
print "<tr>";
print "<td align=\"left\" width=\"312\">";

print "<form action=\"$script\" method=\"POST\">";
print "<li type=\"square\"><font size=\"2\"><i>Select from list</i></f
+ont><BR>";

foreach (@thefiles) {
$choice = $_;    
print "<input type=\"checkbox\" name=\"choice\" value=\"$choice\"><b>$
+choice</b><br>";
}

print "<p><input type=\"submit\" name=\"create_list\" value=\"Create\"
+></p>";
print "</form>";
print "</td></tr></table>";


&Bottom;
}

sub Bottom {
print "<center><br>";
print "<small><small>$footer</small></small>";
print "</center></html>";
}

#### END DISPLAY FORM ####

#### BEGIN CREATION PROCESS ####

sub Create_List {
$choice = "$FORM{'choice'}";
@choices = split(/,/, $choice); 
$selected = @choices;

open FILE,">list.txt" or die "Can't open file:$!\n"; 
foreach (@choices) {
print FILE "$choice\n";
}
close FILE;

&Finished;
}

sub Finished {
&Top;
print "<center><h4>List created</h4>";
print "You selected ($selected):<br><li>$choice</li><br>";
print "<br><A HREF=\"javascript:history.back()\">Go Back...</A></cente
+r>";
&Bottom;
}

#### END PROCESS ####
[download]

Comment on Re: Re: a question about working with the forms and array Download Code

Replies are listed 'Best First'.

Re: Re: Re: a question about working with the forms and array
by arturo (Vicar) on Oct 15, 2003 at 00:28 UTC

Really, seriously, use CGI instead of your hand-rolled procedure. It's been battle-tested, and is amazingly convenient to use; it handles all the URL-encoding and so forth, and deals with (inter alia) URLS that read like /script.pl?foo=bar&baz=bletch, which would mess yours up. CGI will cut way down on the number of lines of code in your script, and make debugging easier. In fact, it's your hand-rolled procedure that appears to be the culprit. What you have in your HTML form, as generated by the script, is something like this:

 <input type="checkbox" name="choice" value="foo.txt">
 <input type="checkbox" name="choice" value="bar.txt">
[download]

two

choice=foo.txt
choice=bar.txt
[download]

$FORM{'choice'}

foo.txt

$FORM{'choice'}

bar.txt

Here's how you'd parse the form with CGI: at the top of your script, put use CGI qw(param); and to get the list of selected files, you'd simply add the one line @files = param('choice');. End of story.

I also want to lean hard on use strict. It may seem like it will make things more painful, but it will force you to think about which subroutines need access to which data. It will make your code so much more maintainable. And, as a final suggestion, I'd suggest you look into using CGI ;)

If not P, what? Q maybe?
"Sidney Morgenbesser"

[reply]
[d/l]
[select]