Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

comment on

( #3333=superdoc: print w/replies, xml ) Need Help??

I believe that for this exact case (for @array) it is safe, despite the warning which has been there very long time, and despite there being no tests for it

I've done it in 5.005 and 5.016 and it worked as expected :) and its perfectly logical, it can't go wrong ( unlike shrinking the size of the array)

I believe the only situation for which the warning applies is shrinking the array (pop/unshift), or replacing parts of it (splice)

http://search.cpan.org/dist/perl5.005/pod/perlsyn.pod#Foreach_Loops
http://perl5.git.perl.org/perl.git/blob/HEAD:/t/cmd/for.t
http://perl5.git.perl.org/perl.git/blob/HEAD:/t/op/push.t
http://perl5.git.perl.org/perl.git/blob/HEAD:/t/op/for.t
http://perl5.git.perl.org/perl.git/blob/HEAD:/t/op/each.t
http://perl5.git.perl.org/perl.git/blob/HEAD:/t/op/splice.t
#9336: Changing a for array dumps core
Deleting specific element in array in FOREACH loop

In any case, warnings doesn't warn you about iterating over an array while you splice over it, but it could

In any case, the tests should be amended to test out the possibilities, to narrow down what is safe and what isn't :) So write up a test and perlbug-it brave soul :)

Also a Perl::Critic policy should be easy to write, see Perl::Critic::Policy::ValuesAndExpressions::UndefinedBehaviourMaybeQuoteit / $1 not quoted (value not frozen) undefined behaviour


In reply to Re: Is it safe to append to the array you are iterating over (yes) by Anonymous Monk
in thread Is it safe to append to the array you are iterating over by DrWhy

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others chanting in the Monastery: (4)
As of 2022-08-08 12:54 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found

    Notices?