Beefy Boxes and Bandwidth Generously Provided by pair Networks
Do you know where your variables are?
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

Some minor suggestions:

  1. In GetFileSize, change this:
    if ($res->is_success) { my $headers = $res->headers; return $headers; }else{ $flag = 1; $error .= "Error retrieving file information at $url "; } return 0;
    To this:
    return $res->headers if $res->is_success; $flag = 1; $error .= "Error ..."; return 0;
  2. Within your for loop, change this:
    if(exists($extens{$ext})){
    To this, and remove one level of indentation.
    next unless exists $extens{$ext};
  3. Change delimiters rather than escaping. And in this example the global modifier isn't necessary.
    #if($newurl !~ /http::\/\/$/ig){ if($newurl !~ m#http:://$#i){
  4. $skips -= 1; vs. $skips--;?
  5. Change this:
    print"\n\n\n$filename at $newurl\n"; print "File size: ".$header->content_length." bytes\n" unless $flag==1 +; print "Last modified: ".localtime($header->last_modified)."\n" unless +$flag==1;
    To this:
    print "\n\n\n$filename at $newurl\n", printf("File size: %d bytes\nLast modified: %s\n", $header->content_le +ngth, localtime($header->last_modified)) unless $flag == 1;
  6. Spelling and grammar...
    #print"\nExtensions to download (seperated by comma's): "; print"\nExtensions to download (separated by commas): ";

    In reply to Re: RFC: Code testers/reviewers needed by hbm
    in thread RFC: Code testers/reviewers needed by AI Cowboy

    Title:
    Use:  <p> text here (a paragraph) </p>
    and:  <code> code here </code>
    to format your post; it's "PerlMonks-approved HTML":



    • Are you posting in the right place? Check out Where do I post X? to know for sure.
    • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
      <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
    • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
    • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others about the Monastery: (3)
As of 2024-04-25 19:34 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found