comment on

Hi Monks!

I am working on this code where I need to send json back to some jQuery code. I would like to know if there is better way of doing this, I mean formatting JSON data. Is there anything that could be done better?
Here is the code sample for your evaluation:

!/usr/bin/perl

use strict;
use warnings;
use CGI::Carp qw(fatalsToBrowser);
use CGI qw(-oldstyle_urls :standard);
use DBI;
use DBD::ODBC;
use Data::Dumper;
use JSON;

my $q = CGI->new;

my $search = $q->param('search') || "";

my $user = "user";
my $pwd  = "pwd";


my $dbh = DBI->connect("DBI:ODBC" ,$user ,$pass ,{ PrintError => 0 } )
+ or
                 die "Can not connect to ODBC database: $DBI::errstr\n
+" ;
 
my $sql = qq{SELECT name,city,state from mytable where name like ? lim
+it 5};
my $data_handle = $dbh->prepare($sql);

   $data_handle->execute($search.'%') or die "SQL Error: $DBI::errstr\
+n";

my %returned_data;

while (my $row = $data_handle->fetchrow_hashref()) {

          $returned_data{'name'}  = $row->{NAME};
          $returned_data{'city'}  = $row->{CITY};
          $returned_data{'state'} = $row->{STATE};
 
}

$data_handle->finish;

print $q->header(-type => "application/json", -charset => "utf-8");
my $json = encode_json \%returned_data;
print $json;
[download]

Thanks for looking!

In reply to Formatting JSON the right way by Anonymous Monk

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


"be consistent"
	PerlMonks