comment on

You know what would really improve the readability? Comments :-)

As for performance, it would probably be better to use List::Util's max() at the end of the inner loop instead of building the max while iterating. You pay for the array access and the subtraction each time you write $sums[$j-$i] You also pay each time you open a scope with curly braces. So maybe:

use List::Util 'max';
...
   $sums[ $_ - $i ] += $_[ $_ ] for $i .. $n-1;
   push @max, max(@sums[0 .. $n-1-$i]);
[download]

I don't know why the run-time would vary every 10th run for you, but if it's in a terminal and you are printing to the screen, your desktop environment could have an effect maybe. I ran this example a bunch of times and they came out to pretty much the same ms each time. But, this example as written only takes 175ms for me which is too tiny to really use as a benchmark. I assume you run with a larger $n?

Also I don't recommend using @_ when you aren't dealing with function arguments. Maybe call it @input or something?

In reply to Re: Performance issue in the loop. by NERDVANA
in thread Performance issue in the loop. by rsFalse

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


good chemistry is complicated, and a little bit messy -LW
	PerlMonks