Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
Newx() is only appropriate if the sizeof the type is a constant

That's a good demo of when it makes better sense to use safemalloc() - but it seems that you can still use Newx() if you want.
Instead of doing:
message = (EdjeMessageStringSet*) safemalloc( sizeof(EdjeMessageString +Set) + (count+1)*sizeof(char*) );
I think the following Newx() rendition does the same thing (and does it portably):
Newx( message, (sizeof(EdjeMessageStringSet) + (count+1)*sizeof(char*) +) / sizeof(char), char );
Of course, that Newx() approach relies on (sizeof(EdjeMessageStringSet) + (count+1)*sizeof(char*)) being an exact multiple of sizeof(char), which is a pretty safe bet whenever sizeof(char) is 1.

TBH, I had never considered the possibility of Newx() being called with the first arg being a pointer to a certain type && the final arg specifying a different type.
I wonder if there's a problem with doing that ... of which I'm currently unaware.
Live and learn .... ;-)

UPDATE:
Another thing that had been nagging at me was "Why does the memory have to be allocated in one hit ?".
The answer, of course, is "It doesn't". It's quite ok (and makes better sense to me) to do the memory allocations separately:
char ** p; EdjeMessageStringSet* message; ... Newx(message, 1, EdjeMessageStringSet; Newx(p, count + 1, char*); ...
and that works quite well.

Cheers,
Rob

In reply to Re^12: Perl XS binding to a struct with an array of chars* by syphilis
in thread Perl XS binding to a struct with an array of chars* by MaxPerl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others goofing around in the Monastery: (4)
As of 2024-03-28 18:28 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found