You're iterating over the list of files twice, once in the grep & once in the foreach, and you don't need to do that. Also glob is easier to use than opendir/readdir, IMHO. So you could have done something like this
use v5.20;
use warnings;
use autodie qw/:all/;
use File::Glob qw/:bsd_glob/;
use File::Spec;
use File::Basename;
sub showtree {
my ($dir,$indent) = @_;
$indent .= ' ';
my @list = bsd_glob(File::Spec->catfile($dir,'*'));
foreach my $f (@list) {
if (-d $f) {
say $indent,'+-',basename($f);
showtree($f,$indent . '|');
}
if (-l $f) {
say $indent,'+-',basename($f),' --> ',readlink($f);
}
}
}
showtree($ARGV[0] // '.');
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|