Beefy Boxes and Bandwidth Generously Provided by pair Networks
Just another Perl shrine
 
PerlMonks  

comment on

( [id://3333] : superdoc . print w/replies, xml ) Need Help??

Consider extracting all the things that look like a year number, and changing the matching logic to first check for the equivalence of the years and then falling back on the five words equivalence. Something like:

my $year_left = ...; my $year_right = ...; my $have_years = ($year_left and $year_right); my $equal_years = ($year_left == $year_right); my $five_words_result = ...; # you already have this above my $final_result; if( ! $have_years ) { $final_result = $five_words_result; } elsif( $equal_years ) { $final_result = $five_words_result; } elsif( ! $equal_years ) { $final_result = undef; # without matching years, things are never +equal } else { die "This should never happen. left=$year_left, right=$year_right, + have_years=$have_years, equal_years=$equal_years"; };

Maybe it would be good to put this logic, together with the logic for finding five or more matching words, into its own function. Consider passing to that function the title on the left side and the title on the right side, and possibly already the extracted year numbers.


In reply to Re: Addional "year" matching functionality in word matching script by Corion
in thread Addional "year" matching functionality in word matching script by bms9nmh

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.