Who was it that suggested the "Principle of Least
Surprise" for component behaviour? I'd say this is
a rather gross violation of that rule. Sure, it's
great to tell the programmer that they may have
called the function improperly, but to die
on ill-formed input, especially in a function that's
supposed to check for validity, is extreme. (By all
means carp about strange input -- bonus
points if you provide a flag for debugging output,
so that end users don't have to wade through a huge
cascade of "hey, programmer, I think you've messed
up" messages from a smart-ass module.)
As an aside, I can't stand the name
'check_date' for that function. Okay, it
checks the date, but what does it do after checking
the date? Die with an error? Return true ("yes,
it's valid")? Return false ("yes, it's bogus")?
Set a flag somewhere? How about is_valid_date
instead?
--
:wq
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|
