Beefy Boxes and Bandwidth Generously Provided by pair Networks
Don't ask to ask, just ask

comment on

( [id://3333] : superdoc . print w/replies, xml ) Need Help??
Yeah, there are simpler ways to keep a list of IPs. As the list grows, time to check them increases tremendously.

If you really must do it this way, use a database. Even something simple like DBD::CSV would help immensely.

Specific things in your code that I'd do differently are:

  • Error checking (always check the return value of open calls!)
  • Open the IP list for appending, at least. ">> listofips.txt". That way, you don't have to write the whole thing at once.
  • Setting $/ to undef and slurping the whole file into a scalar instaed of using read.
But tracking IP addresses really isn't the way to go here, as merlyn and others have pointed out.

In reply to RE: RE: Quick and easy way to prevent multiple votes? by chromatic
in thread Quick and easy way to prevent multiple votes? by Anonymous Monk

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.