I haven't had the opportunity to use Net::LDAP yet, so I will comment on the rest of the code.
Instead of printing line by line, why not use a here-doc for your usage message? Or use Pod::Usage and document your script in POD.
The following might make your defaults stand out more:
my ($user, $pass);
my $host = 'yourserver.yourdomain.com';
my $port = 389;
my $debug = 0;
GetOptions(
'h=s' => \$host,
'p=s' => \$port,
'u=s' => \$user,
'w=s' => \$pass,
'd+' => \$debug,
'q' => \&usage
);
Often, things like if ($debug ne 0) { ... } are better written as if ($debug) { ... }.
I would write debug and status messages to STDERR instead of STDOUT and include $0 (or similar) in error messages.
Hope this helps.
— Arien
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|