You simply forgot to return $txt. A sub returns the result of the last statement by default, in your case this is the substitution. Try this instead:

#!/usr/local/bin/perl -w
use strict;
my $txt="This is a line\nThis is a line as well\n\nThis is the last li
+ne\n";
print ubb_txt($txt);
sub ubb_txt {
  my $txt = shift;
  return "" unless ( defined $txt);
  my ($nl)=$txt =~ m{(\cM?\cJ)};
  $txt =~ s{$nl$nl}{</p><p>}gs if (defined $nl);
  $txt =~ s{$nl}{<br>}gs if (defined $nl);
  return $txt;
}
__END__
This is a line<br>This is a line as well</p><p>This is the last line<b
+r>
[download]

Your sub was returning the number of substitutions made (i.e. the result of the last substitution).

CU
Robartes-

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.