Beefy Boxes and Bandwidth Generously Provided by pair Networks
Syntactic Confectionery Delight
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

By visual inspection I can see a number of errors.

use strict is lacking a semicolon. If you mean to use strictures then you must predeclare all your variables as either package variables (with use vars) or lexical variables (with my).

There is a big conceptual problem with calling localtime repeatedly. What happens if you make the individual calls at the exact moment when the minute, hour, day... wraps around? Instead of getting 4:59:59, you might wind up with 5:00:59. localtime will return an array. Call it once and save the result as an array and then pick out what you want, rather than calling it repeatedly and carving out what you want with array slices.

To zero fill a value, as you do for the minutes, it's much simpler to write $min = sprintf('%02d', $min). Saying $min = $min is what's known as a nop.

Other than that, you're off to a good start. Keep it up, and read as much code by other people as you can.

____________________________________________________________
Join the monks coming to YAPC::Europe 2003 in Paris, 23-25 July 2003.


In reply to Re: Simple Greeter (well, it's a start) by grinder
in thread Simple Greeter by harley_frog

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others imbibing at the Monastery: (2)
As of 2024-04-25 07:46 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found