I don't know if this works - away from my trusty Linuxbox - but it is a good idea. A pure perl Archive::Zip
would be a really _brilliant_ idea - great for app packaging.
A few comments just from reading the source:
- It's a good idea to stick to one subroutine naming convention: like_this or likeThis. In Perl, like_this is preferred as more readable.
- You have an OO interface, so why export functions (esp. automatically)? AFAICS Archive::Tar doesn't do this.
- ... especially as you are exporting functions named the same as Perl core functions (e.g. "read")
- Hmm... do you come from Java? I don't see anything wrong with using $this instead of $self, it is just a bit unusual.
- int $verbose == 0: no need. Just and not $verbose would be fine.
- Similarly, return unless fileno $filehandle; is fine, and avoids non-standard brackets.
I'm just looking for nitpicks, you understand. It seems like very nice, clear code.
Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
Want more info? How to link or
or How to display code and escape characters
are good places to start.