Two things:
1) that while loop should read:
while (<FS>) { $OP .= $_ }
Note the all-important ".=" instead of "=" (probably just
a mistype on your part. :)
2) your opens should always check for error messages, and
you should get faster results slurping the whole file
in as one string, like so:
sub readfile {
my $OP;
open FS, $_[0] or die "Can't open $_[0]: $!";
{
local $/ = undef;
$OP = <FS>;
}
close FS or die "Can't close $_[0]: $!";
return $OP;
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|