# predeclare subroutines so subs; can be called before being declared
# and without ()
subroutines don't have to be declared before you can use them in your code. The don't even have to be declared at compile time. If you are using AUTOLOAD the don't even have to defined when the are executed at runtime.
Also, learning the power of regular expressions will make your code more tighty.
The following one line could replace your code that follows
# one line to make sure there is one and only one "/"
$target_dir=~s<^/*></>;
Could replace all this:
#get first character in target_dir
my $first_char = substr( $target_dir, 0, 1 );
writeLog( "debug - first character in target_dir $target_dir = $first
+_char" ) if ( $debug );
if ( $first_char ne '/' ) {
writeLog( "debug - adding / to beginning of target_dir $target_dir"
+) if ( $debug );
#add "/" to beginning of filepath
$target_dir = '/'.$target_dir;
}
else {
writeLog( "debug - / already exists at beginning. target_dir remains
+ $target_dir" ) if ( $debug );
}
#beginning has already been checked for "/" so check for addl
# "/"s at position 1 ( ///IN/CF/ becomes /IN/CF/ )
#if position 1 is "/" chop it out and continue until position
#1 is not a "/"
writeLog( "debug - checking for multiple '/'s at beginning of target
+dir $target_dir" ) if ( $debug );
my $second_char = substr( $target_dir, 1, 1);
writeLog( "debug - initial second character in target_dir $target_dir
+ = $second_char" ) if ( $debug );
while ( substr( $target_dir, 1, 1) eq '/' ) {
writeLog( "debug - removing / from second character in target_dir $t
+arget_dir" ) if ( $debug );
chop( substr( $target_dir, 1, 1 ) );
writeLog( "debug - target_dir = $target_dir" ) if ( $debug );
}
Also your code has some many comments it makes it hard to read.
#verify that file exists
checkFileExists() if ( ! $interactive );
If your function name is almost exactly the same as your comment, you probably don't need the comment
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.