I expect that the corresponding nested if..else construct would be even more baffling. The weakness here is in the negated and chopped-up logic, not the trinary op. I'll make a first cut at rewriting it:
my $send_now_button =
$auth{'SEND'} && $status==1 && $approved && !$send_now ?
qq( ...blah blah ...) : '';
Not nested, you can use it now ;-)
I think I had an easier time decyphering the (well-formatted!) nested trinary than I would have a similarly built if statement.
Update: Just for fun, here's thing I'm slanging, formatted the best I know how,
my $send_now_button;
if ( !$auth{'SEND'} ) {
$send_now_button = '';
}
else {
if ( $status != 1 ) {
$send_now_button = '';
}
else {
if ( $approved ) {
if ( $send_now ) {
$send_now_button = '';
}
else {
$send_now_button = qq( ...blah blah ...);
}
}
else {
if ( $send_now ) {
$send_now_button = '';
}
else {
$send_now_button = '';
}
}
}
}
Noisy, ain't it? That maybe does even better than the trinary version at pointing out how ludicrous the logic is, but IMO trinary makes it easier to see how to fix it. I didn't even bring elsif to the table :-))
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|