Suggestions:
Provide more information with $! when open fails (you'll apreciate it when it happens).
open (LOGFILE, "< $logfile") or die ("Could not open $logfile: $!");
You're kind of care free when mixing $thiscust with record fields, hash keys and file handles. Maybe something more like this:
$thiscust = (split /\//, $fields[4])[1];
if ( ! $cust{$thiscust} ) {
print "customer $thiscust\n";
$cust{$thiscust} = $thiscust;
open (my $fh, ">> ${prefix}${thiscust}${suffix}")
or die ("Cannot open ${prefix}${thiscust}${suffix}: $!");
$cust{$thiscust} = $fh;
}
my $fh = $cust{$thiscust};
print $fh $_;
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|