|What do I need to check to make sure I'm not letting anything slip by?
As described above, use both taint mode and CGI.pm as follows:
#warnings and taint mode now enabled
#you may now use the CGI methods.
It would scare me greatly if you copied this code from a company web page since those pages are now vunerable to a variety of DoS and hack attacks. CGI
has tested-true functions for nearly everything you do above. It looks like you could reduce that program to 10 lines or less OF SECURE CODE!
On CGI security: If you're not using the inputted data in shell calls, then you're relatively safe. Taint mode specifically checks for this. Of course, some loser can still input some random schlop, so work your CGI with "valid entry or reject"/deny-allow in mind. As I said earlier, CGI.pm provides numerous functions for EXACTLY what you are doing (and doing incompletely), including character escaping, so click that link and read the docs on it.
AgentM Systems nor Nasca Enterprises nor
Bone::Easy nor Macperl is responsible for the
comments made by
AgentM. Remember, you can build any logical system with NOR.
Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
Want more info? How to link
or How to display code and escape characters
are good places to start.