I think this is still not as good style as it could be, personally I don't like if/else for debugging as it apears convoluted to me, I would think this would be better:
exit "Sorry, name can't be empty"
if $name eq ''
;
print "Thank you, $name. Your submission is complete.";
IMHO printing for an error message is bad practice, let a function or a module take care of it, and exit (or better yet die, or croak) with a code or a message.
UPDATE
I didn't know exit() was CORE:: -- news to me. use die instead as said below, I thought this was a user func.
Evan Carroll www.EvanCarroll.com
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|