Beefy Boxes and Bandwidth Generously Provided by pair Networks
Welcome to the Monastery

comment on

( #3333=superdoc: print w/replies, xml ) Need Help??
Module code should localize any special variables it uses in each location it uses them. This is a smart and sane practice. Watch:
package MyConfigReader; sub readConfig { my ($file,$var) = @_; open FILE, "< $file" or die "can't read $file: $!"; while (<FILE>) { chomp; my ($k,$v) = split /=/, $_, 2; return $v if $k eq $var; } close FILE; return; }
That looks innocent, right? Watch it get blown to hell:
use MyConfigReader; $/ = "not gonna happen"; MyConfigReader::readConfig("whatever.dat");
My program has just modified the input record separator variable. The module relied on that being \n, and now it isn't.
sub readConfig { my ($file,$var) = @_; local ($_, $/); $/ = "\n"; # rest of function }
So yes, this is something you should be doing. Trusting the user is potentially silly. Perhaps there should be a switch like -T that catches blind use of "true globals" like you demonstrated.

japhy -- Perl and Regex Hacker

In reply to Re: localization of $_ by japhy
in thread localization of $_ by modred

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?

What's my password?
Create A New User
Domain Nodelet?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others chilling in the Monastery: (3)
As of 2023-09-22 05:34 GMT
Find Nodes?
    Voting Booth?

    No recent polls found