Anywho, here's the distilled example...
In addition to the other good suggestions you got (I hope not to repeat too many of them!) here are a few others:
my @files = ();
No need for the initialization and it doesn't add to clarity IMHO.
find(sub { $File::Find::name =~ m/${directory}(.*)$/; push @files, $1}
+, $directory);
@files = grep { is_dos_format("$directory/$_") } @files;
Rather than collecting filenames in @files to process the latter with grep later, why don't you do so in the first place as files are being searched? If the files are many, then your program should be more responsive. Also, I don't understand the logic of stripping the base directory only to reinsert it later...
foreach my $file (@files) {
print "FAILED FILE - $file\n";
}
Oh, and why another loop too?!? (grep is one in disguise: you're doing it twice when there's no logical reason to.)
if ($_ =~ m/\r\n/) {
The whole point of the $_ pronoun is that it is the topicalizer: you either use an explicit variable name and the binding operator or just the match.
All in all I believe your code may be rewritten like:
#!/usr/bin/perl
use strict;
use warnings;
use File::Find;
my $directory = '/tmp/rja/find_test';
find { no_chdir => 1,
wanted => sub {
return unless -f;
open my $fh, $_ or die "Can't open `$_': $!\n";
my $file=$_;
/\r\n/ and
print "FAILED FILE - $file\n" and return while <$fh>;
} }, $directory;
__END__
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|