You can clean that up a little:
#!/usr/bin/perl
use strict;
use warnings;
# Parse Gaussian '03 output files for the lengths of the bonds in
# Diaminopolymethine Dyes strictly between Carbon and Nitrogen or Carb
+on and
# Carbon
chomp (my $infile = <>);
chomp (my $outfile = <>);
open FILE, '<', $infile or die "Unable to open $infile: $!";
my @inlog =
grep {/\d/ && ! /[a-zA-Z]/ && $_ >= 1}
map {split (/\s/, $_)}
grep {!/h|c{3}?|nc{2}?|(estimate)|c{2}?n{1}?/}
grep {/^\s?!{1}?\s*(c|n)/} <FILE>;
close FILE;
open LOG, '>', $outfile or die "Unable to create $outfile: $!";
print LOG join "\n", @inlog;
close LOG;
Your version had some rather odd constructs. The pop loops to clear out arrays were perhaps the strangest. Much better to:
@array = ();
The while loop to slurp the file is better as:
@array = <FILE>;
The construct my $infile, my $outfile; is odd. Either my ($var1, $var1); or use two separate statements:
my $var1;
my $var2;
However you should declare your variables as close to their first use as possible so it is not often that you need to declare a bunch of variables in one place like that anyway. See too the file name variable declarations in my version of your code above.
You should always use the three parameter version of open and you should always check the result.
Perl is environmentally friendly - it saves trees
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.