comment on

I tend to use goto quite liberally. For example, below, I want to exit the sub if the $project does not have the IconView initialized yet. Also, if no items were selected, I want to return. In both cases I want to give the same warning and return.

eval the get_selected_items and check for error
do a return instead of goto
...

But, to me, this seems like it is much easier (and clearer) to use goto instead of coming up with all possible structures and so on just to avoid using goto.

    goto NO_EXIF unless (defined($project->{LG}->{IMG_ICONVIEW}));

    my @img_selected = $project->{LG}->{IMG_ICONVIEW}->get_selected_it
+ems();
    my @dock_selected = $project->{LG}->{DOCK_ICONVIEW}->get_selected_
+items();

    ## check that any images are selected
    if (scalar(@img_selected) + scalar(@dock_selected) < 1) {
      NO_EXIF:
    GUIFunctions->warn("Some message");
    return;
    }
[download]

In reply to Re^2: Number of times I've used goto in Perl by Anonymous Monk
in thread Number of times I've used goto in Perl by vroom

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


go ahead... be a heretic
	PerlMonks