You can simplify that wantarray call by adding a return in front and then letting the ternary operators do the rest like so:
return wantarray ? @file : join '', @file;
And here is my slightly changed version of your code.
#!/usr/bin/perl
sub io
{
# usage:
# @array = io('read',$file)
# $string = io('read',$file)
# io('write',$file,\$string)
# io('write',$file,\@array)
my($bit,$file,$data) = @_;
if($bit eq 'read'){
open IO,"< $file" or die "Cannot open $file for input: $!\n";
my @file = <IO>;
close IO;
return wantarray ? @file : join '', @file;
}
if($bit eq 'write'){
open IO,"> $file" or die "Cannot open $file for output: $!\n";
print IO ref $data eq 'ARRAY' ? @$data : ref $data eq "SCALAR"? $
+$data : '';
close IO;
}
}
$string = "YO!";
io('write','file.txt',\$string);
This way everything is passed as references and it deletes an extra line of code. :)
$_.=($=+(6<<1));print(chr(my$a=$_));$^H=$_+$_;$_=$^H;
print chr($_-39); # Easy but its ok.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.