Make sure you return the value in your sub routine. Something like:

my $variable = results();

sub results {

   # ... do something that will give $foo the stuff you want
   #     to return ...

   return $foo;
}
[download]

sub results {
  return 
"Name:xxx
Address: Main street
City: Boston
Phone: 123 234 2345"

}
$variable = &results();
print $variable;
[download]

Here is the code but it still doesn't work.


my $xx = &log;
print "<b>$xx</x>";
[download]


Don't know why???

sub log
{
my $log_file = "log.txt";
open(LOGFILE, "$log") or die("Could not open log file.");
#my %seen;
my %seen = ();
my %typeseen = ();

# read it in
my $test = "Home Company";
while(<LOGFILE>)
{
    next unless /($test)\*(.*?)\*(.*?)\*(.*?)\*(.*?)\*(.*?)\*(.*?)\*(.
+*?)$/;

    my ($item, $logintype) = ($1, $4);
    #print $item;
    $seen{$item}++;
    $typeseen{$item}{$logintype}++;
}

# dump it out
foreach my $item (sort keys %seen)
{
  print "$item:<br>\n";
  print "\tLog in activity: ", $seen{$item}, "<br>\n";

  foreach my $type (sort keys %{$typeseen{$item}})
  {
    print "\t", $type, " activity: ", $typeseen{$item}{$type}, "<br>\n
+";

 }

}        
    
} ####### END SUB LOG
[download]

Your subroutine prints out information, rather than returning it. If you want to capture what is printed into a variable, you would need to have it run as a separate process (see fork) so that you can read its STDOUT. (Or, the easier way, just have it build up a string and return that, as so many others have suggested.)

---

The PerlMonk tr/// Advocate

If you don't want to change the code in the subroutine to accumulate and return a string, instead of printing, you can try the following. Similar but prettier techniques use non-standard modules.

# somewhere near the top of your code, put this:
{
  package AccumHandle;
  sub TIEHANDLE { my( $pkg, $s ) = shift; bless \$s, $pkg }
  sub PRINT { my $self = shift; $$self .= join($,,@_).$\; }
}


# now do this where you call the subroutine:

  local ACC;
  tie *ACC, 'AccumHandle';
  select ACC;
  &log();
  select STDOUT;
  my $xx = ${tied(*ACC)};
  print "<b>$xx</x>";
[download]

Btw - this question is a (currently unapproved) Categorized Question: How can I write a function's output to a scalar?.

jdporter
The 6th Rule of Perl Club is -- There is no Rule #6.

You must use the return statement inside your subroutine. I am not sure I understand exactly what you are trying to do from reading your code, but I am assuming you want everything you are printing to be returned (Update and not printed). In that case you need to put the data in the variable first, then return it. Like this.... (code not tested)

my $output;
foreach my $item (sort keys %seen)
{
  $output .= "$item:<br>\n";
  $output .= "\tLog in activity: ", $seen{$item}, "<br>\n";

  foreach my $type (sort keys %{$typeseen{$item}})
  {
    $output .= "\t", $type, " activity: ", $typeseen{$item}{$type}, "<
+br>\n";
 }
 return $output;

}
[download]

log is a builtin function (logarithm) so it is not a wise idea to define a new function with the same name. While it might not be the problem in this case, you should avoid this in the future not to fall in the trap. (I once tried to define a log function in C.)

($name, $address, $city, $phone) = &getInfo();

print "Name: $name\nAddress: $address\nCity: $city\nPhone: $phone";

sub getInfo(){
    return ("xxx", "Main street", "Boston", "123 234 2345");
}
[download]

sub results {
    # Guessing that the results are in separate variables $name,
    # $address, $city, $phone:
    return {
        name    => $name,
        address => $address,
        city    => $city,
        phone   => $phone,
    };
}
[download]

my $info = results();
print "Name: " . $info->{name} . "\n";
# And of course $info->{address}, $info->{city} and $info->{phone}
[download]

Arjen

# create a variable to store the output in
my $output = "";
# open a "file" that will store output in the variable
# (requires 5.8; before that use CPAN module IO::Scalar)
open my $fh, ">", \$output or die "Unexpected open to scalar failure: 
+$!";
# save the default output file handle
my $select_save = select($fh);
# call your function
call_function();
# clean up
select($select_save);
close $fh;

# use output
print "Got output: $output\n";
[download]