Moving .doc Files

bkiahg has asked for the wisdom of the Perl Monks concerning the following question:

Hello Monks,

I think I'm missing something simple. I'm trying to move a file before I delete it. And the way I'm trying it gives me a blank word doc in the deleted folder.

#! C:\perl\bin\perl.exe

use strict;
use CGI qw(fatalsToBrowser);

my $file = "C:\\web\\policies\\folder\\file.doc";
my ($bytesread, $buffer);

print "Content-type: text/html\n\n";

open (DOC, $file) or die "cannot open: $!";
my @doc = <DOC>;
close DOC;

open (NEWDOC, ">C:\\web\\policies\\folder\\deleted\\file.doc") or die 
+"Cannot open new: $!";
binmode (NEWDOC);
while ($bytesread=read(@doc,$buffer,1024))  {
     print OUTFILE $buffer;
}
close NEWDOC;

print "completed!";

foreach (@doc) {print}
[download]

Any help is very appreciated.

Comment on Moving .doc Files Download Code

Replies are listed 'Best First'.
Re: Moving .doc Files by amw1 (Friar) on Jun 23, 2004 at 19:37 UTC
Why not just move the file? `perldoc File::Copy` [download]	[reply] [d/l]
Re^2: Moving .doc Files by bkiahg (Pilgrim) on Jun 23, 2004 at 19:48 UTC
That worked!! Thanks!!!	[reply]
Re: Moving .doc Files by kelan (Deacon) on Jun 23, 2004 at 21:08 UTC
How about this: `# open them my $old = "something.doc"; my $new = "somethingelse.doc"; open OLD, '<', $old or die "Can't open old: $!\n"; open NEW, '>', $new or die "Can't open new: $!\n"; binmode OLD; # only need these on windows binmode NEW; # copy print NEW <OLD>; # close them close OLD; close NEW;` [download]	[reply] [d/l]
Re^2: Moving .doc Files by bkiahg (Pilgrim) on Jun 23, 2004 at 23:00 UTC
That worked also! `File::Copy` will suffice for this particular project, but its always good to know how to do it with less code. Thanks!	[reply] [d/l]
Re: Moving .doc Files by NetWallah (Canon) on Jun 23, 2004 at 19:38 UTC
You are trying to read and array! Delete the lines starting "my @doc" and "close DOC" Change "read(@doc" to "read(DOC" Add "close DOC" before you close NEWDOC You will probably need "binmode" on DOC as well Earth first! (We'll rob the other planets later)	[reply]
Re^2: Moving .doc Files by bkiahg (Pilgrim) on Jun 23, 2004 at 19:49 UTC
That didn't work, but `File::Copy` does what I was looking for.	[reply] [d/l]
Re: Moving .doc Files by gawatkins (Monsignor) on Jun 23, 2004 at 20:42 UTC
In addition to the suggestion for `File::Copy` you could use the system move command: `opendir (DIRHANDLE, $OLDDIR); while ($oldname = readdir(DIRHANDLE)) { chomp $oldname; $filename = "$OLDDIR\\$oldname"; $newname = "$DIR\\$oldname"; if (-f $filename) { system("move", $filename, $newname); } } closedir (DIRHANDLE);` [download] Just a diffrent way to do it. Greg W	[reply] [d/l] [select]
Re: Moving .doc Files by ercparker (Hermit) on Jun 26, 2004 at 17:00 UTC
`#I would use perl function rename : #can check $! for success #1 for success rename "/path/to/oldfilename", "/path/to/the/newfilename";` [download]	[reply] [d/l]


Think about Loose Coupling
	PerlMonks