Beefy Boxes and Bandwidth Generously Provided by pair Networks
We don't bite newbies here... much

Re: Re: Re: Re: Re: File copy progress.

by Kanji (Parson)
on Dec 06, 2000 at 07:03 UTC ( #45165=note: print w/replies, xml ) Need Help??

in reply to Re: Re: Re: Re: File copy progress.
in thread File copy progress.

You probably don't want to be using a prototype of () for this sub as you'll be trying to pass arguments to a sub that (regardless of the shifts inside the sub) doesn't take any!

You can also simplify things greatly by performing another sum (to get rid of that case: { ... })in combination with a single printf()...

sub FileProgress { my $wrote = shift; my $size = shift; my $percent = $wrote / $size * 100; printf "\r[%-10s] %3u%% done. %u bytes", '*' x int( $percent / 10 ), $percent, $wrote; return 1; }


Update: Removed the trailing \n.

Replies are listed 'Best First'.
Re: Re: Re: Re: Re: Re: File copy progress.
by zzspectrez (Hermit) on Dec 06, 2000 at 10:41 UTC

    Cool!!!! I didnt think of using the repeat operator. Thats what I like about sharing your code here, someone usually allways has a good suggestion about how to do something better or a way to simplify. I had a problem getting the % to work in the printf.. I looked in the camel book and didnt see any example or explanation. I tryed escaping it like \%.. I didnt think of trying %%.

    One minor correction... The trailing \n needs to be removed from printf so that the status is displayed on the same line.

      use warnings; use strict; $| = 1; #sets buffer to immediately flush my $mydir = 'C:\some\path'; my $destination = 'C:\some\other\path'; opendir (MYDIR, $mydir) or die "Could not opendir $mydir: $!\n"; my @files = grep { /\.ext$/} readdir MYDIR; closedir(MYDIR); for (@files) { &CopyFileProgress("$mydir\\$_","$destination\\$_",\&FileProgress); print "\n"; } sub CopyFileProgress ( ) { my $src = shift; my $dst = shift; my $callback = shift; my $num_read; my $num_wrote; my $buffer; my $total_written = 0; open (SRC, "< $src") or die "Could not open source file [$src]: $! +\n"; open (DST, "> $dst") or die "Could not open destination file [$dst +]: $!\n"; binmode SRC; binmode DST; my $filesize = (-s $src) or die "File has zero size.\n"; my $blksize = int ($filesize / 10); while (1) { $num_read = sysread(SRC, $buffer, $blksize); last if ($num_read == 0); die ("Error reading from file [$src]: $!\n") if (!defined($num +_read)); my $offset = 0; while ($num_read){ $num_wrote = syswrite(DST,$buffer,$num_read,$offset); die ("Error writing to file [$dst]: $!\n") if (!defined($n +um_wrote)); $num_read -= $num_wrote; $offset += $num_wrote; $total_written += $offset; } my $filename = basename($src); &$callback($filename, $total_written, $filesize) or die ("Copy + canceled.\n"); } } sub FileProgress { my $filename = shift; my $wrote = shift; my $size = shift; my $percent = $wrote / $size * 100; printf "%s [%-10s] %3u%% done. %5u MBs\r", $filename, '*' x int( $percent / 10 ), $percent, $wrote / 1024 / 1024; return 1; }
      Very nice, thank you!!

Log In?

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://45165]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others drinking their drinks and smoking their pipes about the Monastery: (4)
As of 2023-06-03 18:47 GMT
Find Nodes?
    Voting Booth?
    How often do you go to conferences?

    Results (16 votes). Check out past polls.