Re: Complex Data Structure Suggestions Wanted

the if... else can be expressed a bit more elegantly:

@{$HashRef->{$ItemId}} ||= [];
push @{$HashRef->{$ItemId}}, $DataSource;
[download]

apart from that: the notation of variable names you chose is not perlish. in perl you mix capital and small letters only for class names: package MyClass; vs: my $hash_ref;

language is a virus from outer space.

Comment on Re: Complex Data Structure Suggestions Wanted Select or Download Code

Replies are listed 'Best First'.

Re^2: Complex Data Structure Suggestions Wanted
by Ninthwave (Chaplain) on Jun 07, 2005 at 13:44 UTC

Thank you for the help.

I will have to disagree with you on variable naming convention though. Because perl does not have a rule for variable naming conventions in the language and this is internal code I use a convention that helps me explain what the variable is quickly. I use multiple words that describe the data as exact as possible. I use capitals to keep multiple words from blurring instead of underscores. Now if I wanted this to be a module for CPAN I would use the perl style guide. And I would simplify the variables to be few and one worders, so all lowercase.

And I do have comments to explain variable so this is a bit overkill but when you are staring at chunks of code a good variable name will save you the second window that is stuck at your table of variable definitions.

But I think this would be more of a meditation than a discussion on a question.

"No matter where you go, there you are." BB

[reply]


Welcome to the Monastery
	PerlMonks