As in, "What not to do?" {grin}
Let's see:
- The "lincoln loader" instead of SelfLoader: check
- Custom importer instead of Exporter: check
- Funky "is this a method or a subroutine" repeated everywhere: check
- Funky "args preceded by dash and/or args inside a hashref": check
- Odd mix of globals and/or use parameters and/or object instance vars to determine behavior: check
Admittedly, some of this stuff was created before the core functionality was available. But there's some mighty scary code in there.
In Lincoln's defense, this code is probably the second most frequently invoked module, after strict, and has had to deal with a lot of legacy issues.
| [reply] |
| [reply] |
Oh, several reasons. Most of all, it does some things I think were a major mistake, like trying to determine whether a sub is called as a function or as a method, at runtime.
Furthermore, it has its own "optimization" using AUTOLOAD, defining sub definitions as strings and evalling them at runtime when the sub is first called. Again, it's not something I want to see in every module.
Leave out those major stumbling blocks (for me anyway), and you do get some readable code, I agree. But the module is still too big for its own good.
I'm quite convinced there must be many much better examples of modules to use as a model on how to do things.
| [reply] |
