HOP Iterator Ex4.3-- Illegal declaration

ady has asked for the wisdom of the Perl Monks concerning the following question:

Fellow Monks, --
I'm playing with a directory parsing based on example 4.3 from HOP v.1:

### Iterate.pl
use strict;
use warnings;
use Iterator_Utils;
# ---------------------------------------------------------
sub interesting_files {
 my $is_interesting = shift;
  my @queue = @_;
  return Iterator {
    while (@queue) {
      my $file = shift @queue;
      if (-d $file) { 
        opendir my $dh, $file or next;
        my @newfiles = grep {$_ ne "." && $_ ne ".."} readdir $dh;
        push @queue, map "$file/$_", @newfiles;
      }
      return $file if $is_interesting->($file);
    } 
    return;
  };
}
# --------------------------------------------------------
sub $is_WrappedXml {
    my $file = shift;
    return 1 if $file =~ /WrappedXml.{0,5}\.xml/i;
    return;
}
# --------------------------------------------------------
# MAIN
my $WrappedXml_file = interesting_files(\$is_WrappedXml, '.');
while (defined($file = NEXTVAL($WrappedXml_file))) 
    print $file;
}
[download]

where

### Iterator_Utils.pm
package Iterator_Utils;
use base Exporter;
@EXPORT_OK = qw(NEXTVAL Iterator);
%EXPORT_TAGS = ('all' => \@EXPORT_OK);

sub NEXTVAL { $_[0]->() }
sub Iterator (&) { return $_[0] }
1;
[download]

When running program Iterate.pl i get the error:
C:\tmp>Iterate
Illegal declaration of anonymous subroutine at
C:\tmp\Iterate.pl line 26.

Any ideas why the Iterator {...} construct is illegal in this context ??

Best regards,
Allan Dystrup

Comment on HOP Iterator Ex4.3-- Illegal declaration Select or Download Code

Replies are listed 'Best First'.
Re: HOP Iterator Ex4.3-- Illegal declaration by Fletch (Bishop) on Mar 03, 2006 at 15:42 UTC
The problem is probably with this line: `sub $is_WrappedXml {` [download] You either want a named sub (drop the `$`) or you want `my $is_WrappedXml = sub { ... }`.	[reply] [d/l] [select]
Re^2: HOP Iterator Ex4.3-- Illegal declaration by ady (Deacon) on Mar 03, 2006 at 15:46 UTC
ooOOOOOPPPss, Yes of course -- some months since i've been in Perl land... sorry- but Thanks! Allan	[reply]
Re^3: HOP Iterator Ex4.3-- Illegal declaration by ady (Deacon) on Mar 03, 2006 at 15:53 UTC
Ok, up n' running : use strict; use warnings; ### -------------------------- Util ----------------------- sub Iterator (&) { return $_[0] } sub NEXTVAL { $_[0]->() } ### -------------------------- Iterator ------------------- sub interesting_files { my $is_interesting = shift; my @queue = @_; return Iterator { while (@queue) { my $file = shift @queue; if (-d $file) { opendir my $dh, $file or next; my @newfiles = grep {$_ ne "." && $_ ne ".."} readdir + $dh; push @queue, map "$file/$_", @newfiles; } return $file if $is_interesting->($file); } return; }; } ### -------------------------- FileMask ------------------- sub is_WrappedXml { my $file = shift; return 1 if $file =~ /WrappedXml.{0,5}\.xml/i; return; } ### -------------------------- MAIN ----------------------- my $WrappedXml_file = interesting_files(\&is_WrappedXml, '.'); while (defined(my $file = NEXTVAL($WrappedXml_file))) { print "$file\n"; } [download] Best regards, Allan Dystrup	[reply] [d/l]


Do you know where your variables are?
	PerlMonks